🐛 make sure singular is always false by default while using loadMicroApp (#1168)

Co-authored-by: gongshun <gongshun@gridsum.com>
This commit is contained in:
gongshun 2020-12-24 12:59:52 +08:00 committed by GitHub
parent aa84eaa289
commit 1c1c1aa075

View File

@ -79,7 +79,8 @@ export function loadMicroApp<T extends ObjectType>(
* the micro app would not load and evaluate its lifecycles again
*/
const memorizedLoadingFn = async (): Promise<ParcelConfigObject> => {
const { $$cacheLifecycleByAppName } = configuration ?? frameworkConfiguration;
const userConfiguration = configuration ?? { ...frameworkConfiguration, singular: false };
const { $$cacheLifecycleByAppName } = userConfiguration;
const container = 'container' in app ? app.container : undefined;
if (container) {
@ -96,7 +97,7 @@ export function loadMicroApp<T extends ObjectType>(
}
}
const parcelConfigObjectGetterPromise = loadApp(app, configuration ?? frameworkConfiguration, lifeCycles);
const parcelConfigObjectGetterPromise = loadApp(app, userConfiguration, lifeCycles);
if (container) {
if ($$cacheLifecycleByAppName) {