From 521efb828d2fce1b393026894417a0f0878f233f Mon Sep 17 00:00:00 2001 From: Kuitos Date: Wed, 7 Jun 2023 11:17:57 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20document.head.removeChild=20shou?= =?UTF-8?q?ld=20be=20hooked=20in=20sandbox=20(#2522)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/sandbox/patchers/dynamicAppend/forStrictSandbox.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/sandbox/patchers/dynamicAppend/forStrictSandbox.ts b/src/sandbox/patchers/dynamicAppend/forStrictSandbox.ts index ac79c94..34ba276 100644 --- a/src/sandbox/patchers/dynamicAppend/forStrictSandbox.ts +++ b/src/sandbox/patchers/dynamicAppend/forStrictSandbox.ts @@ -95,6 +95,7 @@ function patchDocument(cfg: { sandbox: SandBox; speedy: boolean }) { const qiankunHead = getAppWrapperHeadElement(containerConfig.appWrapperGetter()); qiankunHead.appendChild = HTMLHeadElement.prototype.appendChild; qiankunHead.insertBefore = HTMLHeadElement.prototype.insertBefore; + qiankunHead.removeChild = HTMLHeadElement.prototype.removeChild; return qiankunHead; } break; @@ -247,13 +248,13 @@ export function patchStrictSandbox( // all dynamic style sheets are stored in proxy container const { dynamicStyleSheetElements } = containerConfig; - const unpatchDocument = patchDocument({ sandbox, speedy: speedySandbox }); - const unpatchDynamicAppendPrototypeFunctions = patchHTMLDynamicAppendPrototypeFunctions( (element) => elementAttachContainerConfigMap.has(element), (element) => elementAttachContainerConfigMap.get(element)!, ); + const unpatchDocument = patchDocument({ sandbox, speedy: speedySandbox }); + if (!mounting) calcAppCount(appName, 'increase', 'bootstrapping'); if (mounting) calcAppCount(appName, 'increase', 'mounting');