From 52b1a3c44149090dba3773b0024a0a960b944343 Mon Sep 17 00:00:00 2001 From: Kuitos Date: Thu, 9 Feb 2023 21:58:08 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20should=20trigger=20scripts=20loa?= =?UTF-8?q?ding=20before=20them=20executing=20(#2389)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/loader.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/loader.ts b/src/loader.ts index 2576532..4242eb0 100644 --- a/src/loader.ts +++ b/src/loader.ts @@ -263,7 +263,9 @@ export async function loadApp( } = configuration; // get the entry html content and script executor - const { template, execScripts, assetPublicPath } = await importEntry(entry, importEntryOpts); + const { template, execScripts, assetPublicPath, getExternalScripts } = await importEntry(entry, importEntryOpts); + // trigger external scripts loading to make sure all assets are ready before execScripts calling + await getExternalScripts(); // as single-spa load and bootstrap new app parallel with other apps unmounting // (see https://github.com/CanopyTax/single-spa/blob/master/src/navigation/reroute.js#L74)