guawazi/qiankun-fit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

🐛 avoid document.all accessing error in safari (#2575)

Browse Source
This commit is contained in:
Kuitos 2023-08-07 16:02:23 +08:00 committed by GitHub
parent 69759a57e5
commit c89c7538c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/utils.ts
View File

@ -71,20 +71,18 @@ export function isConstructable(fn: () => any | FunctionConstructor) {
return constructable; return constructable;
} }
/**
* in safari
* typeof document.all === 'undefined' // true
* typeof document.all === 'function' // true
* We need to discriminate safari for better performance
*/
const naughtySafari = typeof document.all === 'function' && typeof document.all === 'undefined';
const callableFnCacheMap = new WeakMap<CallableFunction, boolean>(); const callableFnCacheMap = new WeakMap<CallableFunction, boolean>();
export function isCallable(fn: any) { export function isCallable(fn: any): boolean {
if (callableFnCacheMap.has(fn)) { if (callableFnCacheMap.has(fn)) {
return true; return true;
} }
const callable = naughtySafari ? typeof fn === 'function' && typeof fn !== 'undefined' : typeof fn === 'function'; /**
* We can not use typeof to confirm it is function as in some safari version
* typeof document.all === 'undefined' // true
* typeof document.all === 'function' // true
*/
const callable = typeof fn === 'function' && fn instanceof Function;
if (callable) { if (callable) {
callableFnCacheMap.set(fn, callable); callableFnCacheMap.set(fn, callable);
} }